fix(python): npe in request options merge method #4612
Conversation
No code generatedIf you believe code should've been generated, please, report the issue. 📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
|
||
| for key, value in _user_request_options.items(): | ||
| request_options[key].update(value) | ||
| if request_options[key] is None: |
There was a problem hiding this comment.
L68 there's a default for the None parameters, maybe do the same for data?
There was a problem hiding this comment.
I was hesitant because in other languages, if there are data set in the request options, we overwrite the original object.
It's not the case in python (yet), but I thought it was more safe to handle it carefully that way, to prevent any misbehaviour if we make the code more consistent with the other languages in the future
There was a problem hiding this comment.
I don't think we will go to that level of consistency honestly it seems too much but your solution works as well so i'm good with it!
algolia/api-clients-automation#4612 Co-authored-by: Thomas Raffray <[email protected]>
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
datacan beNoneinrequest_options